Timestamps are in GMT/BST.
[17:32] -NickServ- This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.
[17:32] * _eye_fill_in (n=PircBot@c202046.adsl.hansenet.de) has joined #arianne
[17:32] * Topic is 'Stendhal 0.72 and Marauroa 2.6 released: http://arianne.sourceforge.net/?arianne_url=games/game_stendhal#downloadsection][ public server: http://stendhal.game-host.org ][ want to chat?: /join #arianne-chat ][ ANY QUESTIONS?: Just ask them and stick around in the channel, maybe an answer will pop up later ]'
[17:32] * Set by kymara on Sun Feb 22 23:37:04 CET 2009
[17:34] <kymara> durkham: i wanted to check if you thought adventure island thingy
[17:34] <kymara> should not be included in this release? [09:33]
[17:34] <kymara> <kymara> you said something to kiheru like the dynamically created zones were
[17:34] <kymara> still experimental - so if they're too unstable i can remove that
[17:34] <kymara> part from release easily
[17:35] [freenode-connect VERSION]
[17:50] <madmetzger> kymara:i did not test adventure island yet
[17:50] <kymara> that wasn't really what i wanted to know
[17:51] <madmetzger> i am not sure how unstable dynamical zones are
[17:51] <kymara> it was more than durkham said she'd asked that dynamically created zones not be used yet (i hadn't realised that's what she meant)
[17:51] <madmetzger> we are already using it for the vault
[17:51] <kymara> i thought we only weren't uspposed to experiment with them (i.e. not do totally new things)
[17:51] <kymara> i thought creating them with npc like vault is created was ok, but then there was a comment where it made me realise i had misunderstood
[17:53] <kymara> so now i don't know if they are ok or not ... they're getting heavy use the bank vaults but maybe new cases are worse, i don't know
[17:53] <kymara> but i can easily remove from release
[17:54] <madmetzger> hm... if i look at bug requests, i think we found some problems with dynamically created zones
[17:54] <kymara> open ones?
[17:54] <madmetzger> no
[17:54] <kymara> i mean, i found a bunch in testing too. like if a creature died in there the zone was torn down etc etc
[17:54] <madmetzger> most of them are fixed now (teleport thingy, lost items)
[17:55] <madmetzger> so i think it is ripe enough to have it on main
[17:56] <kymara> for the island we don't return items on ground to player
[17:57] <kymara> but we warn them about it. tbh the bank vaults were much more likely to have items on ground than island. you just go there to kill creatures
[17:57] <madmetzger> was just an example on things you have to think of for dynamic zones
[17:57] <kymara> yep
[17:57] <kymara> if you want to see it you can teleportto Haastaja
[17:57] <kymara> you will need new cvs client for the border of the iland
[17:57] <kymara> island
[17:57] <madmetzger> so we learned some lessons on them and i would like to see it in release
[17:58] <madmetzger> i can have a look later this evening
[17:58] <kymara> ok
[17:58] <kymara> and i'm sorry for not understanding before. i had thought it was close enough to existing features to be safe
[17:59] <madmetzger> i am still working on persistence of trade things, but i am not sure if my way is right.
[17:59] <madmetzger> ^^when do you plan to do release?
[18:00] <kymara> i've branched already and there's no release blockers. i could release tonight, or tomorrow
[18:00] <kymara> maybe better tomorrow as i'm a bit tired, and it'd give chance for some more testing tonight
[18:00] <madmetzger> i agree
[18:01] <madmetzger> as durkham is not here atm, could you have a look at my tries, if i commit them, kymara?
[18:01] <kymara> sure. do you mean like how the zone storage is done?
[18:02] <madmetzger> yep
[18:02] <kymara> you put a store() in every constructor for your object. then you create another way to construct the object when you want to resurrect it from the db, and you also make a transformer that takes the marauroa RP object and gives a stendhal rp object that uses the constructor you just made
[18:02] <kymara> but yes i will look
[18:03] <madmetzger> thanks kym
[18:04] <kymara> from then on you have to be really careful with them as if you create them they really stick around :D kiheru got some very interesting ways to remove teh restored objects
[18:12] <yoriy> kym, i tested island with you, remember it? i think if island zone will not depends on other zones and vice versa, it can be included in release, and if some amounts of bugs still exist in that part of code, it will be reported in future through tracker.
[18:15] <kymara> of course i remember testing with you yoriy
[18:15] <kymara> :)
[18:15] <yoriy> :-)
[18:26] <kymara> how embarassing i found a bug in it :D
[18:27] <kymara> there's a very rare chance that the challenger can't fit 5 creatures in the space
[18:27] <kymara> then he charges you less money
[18:27] <kymara> but i had left it as integer division so he charged you 0
[18:27] <kymara> i'd reproduced the rare event before but not after he started charging less
[18:27] <kymara> bad bad kym
[18:33] <yoriy> ah, you mean 5 balrogs :-)
[18:34] <kymara> no, he managed to spanw 2 creatures
[18:34] <kymara> so he should have charged me 2/5 normal price
[18:34] <kymara> but in integer division 2/5 = 0
[18:34] <kymara> not 0.4
[18:34] <yoriy> hm
[18:35] <kymara> so i am testing the fix now
[18:35] <kymara> :)
[18:35] <yoriy> there is a chance to force him place all 5 creatures?
[18:35] <kymara> sure but it's not worth it for the server pathfinding
[18:36] <kymara> in fact i stop him trying quite early. i don't want to clog up server :)
[18:36] <yoriy> maybe btw replacing big creatures to small ones?
[18:36] <kymara> players love seeing balrogs hence i didn't exclude them from there
[18:36] <yoriy> yes :-)
[18:36] <yoriy> ok
[18:37] <kymara> if he fails he just tries again with another random creature in range
[18:37] <kymara> but there's a limit to how many times i left him fail in all before he just creates the zone with however many he has
[18:38] <kymara> which will be much better for server performance
[18:38] <kymara> you thought it was ok, when you tried it though?
[18:42] <CIA-19> arianne_rpg: kymara * stendhal/src/games/stendhal/server/maps/magic/house1/ChallengerNPC.java: use correct division for calculating reduced cost when challenger can't fit in all creatures
[18:43] <CIA-19> arianne_rpg: kymara VERSION_00_RELEASE_73 * stendhal/src/games/stendhal/server/maps/magic/house1/ChallengerNPC.java: backport bugfix
[18:50] <kymara> testserver is updated to 0.73 and the new client 0.73 is there too for it
[18:53] <yoriy> yes, i think so
[19:00] <kymara> i know it is, i just did it :P
[19:00] <kymara> ah you mean yes to the previous question :D
[19:20] <yoriy> yes :-) sorry, was busy :-)
[19:22] * neoneurone (n=chatzill@shm67-4-82-242-215-135.fbx.proxad.net) has joined #arianne
[19:49] * Bluelads4 (i=5084d462@gateway/web/ajax/mibbit.com/x-4b67b6e11a933825) Quit ("http://www.mibbit.com ajax IRC Client")
[20:08] * Bluelads4 (i=5084d462@gateway/web/ajax/mibbit.com/x-d4798186f4842c72) has joined #arianne
[20:18] * Ci-Dev (n=ci-dev@p54BDD10C.dip.t-dialin.net) has joined #arianne
[20:24] <postman-bot> iron rented a sign saying "hi, i buy 1 chaos hornet helmet , 1 chaos legs and 1 chaos armor when you have then send me a msg"
[20:31] <kymara> the island leads to more of the nasty messages about unclean removal of corpses (we tell the turn notifier dontNotify but it doesn't listen :(
[20:31] <kymara> i think *destroy of corpses does too
[20:58] <kymara> am i being really dense, i can't find where the method 'addEvent' is
[20:58] <kymara> e.g. line 901 of src/games/stendhal/server/entity/player/Player.java:addEvent(new PrivateTextEvent(type, text));
[20:59] <kymara> either i'm missing something or it's not in stendhal, maybe it's a maraura thing
[21:00] <kymara> ahh yes that's it it's in marauroa rpobject
[21:00] <kymara> i'm trying to trace why the examine chat action is going wrong
[21:00] <kymara> liek monogenes map
[21:00] <kymara> i tried putting in an exception for if the generateRPClass in ExamineEvent failed, but it didnt' tell me it failed yet i didn't get the map
[21:00] <kymara> so now i'm wondering if it's from addEvent
[21:08] <madmetzger> do you use eclipse? you could try to step through the code
[21:09] <kymara> not on this machine, eclipse is way too demanding for it
[21:09] <madmetzger> ah, okay... another way could be to put debug-messages in the code
[21:11] <kymara> a lot of the generate RP Class bits have a try catch around them, this didn't
[21:12] <kymara> so i thought i'd try it
[21:14] <madmetzger> hm...
[21:15] * CIA-19 (n=CIA@208.69.182.149.simpli.biz) Quit (bartol.freenode.net irc.freenode.net)
[21:15] * kymara (n=user@lxkatie.macs.hw.ac.uk) Quit (bartol.freenode.net irc.freenode.net)
[21:15] <Bluelads4> :(
[21:16] * CIA-19 (n=CIA@208.69.182.149.simpli.biz) has joined #arianne
[21:16] * kymara (n=user@lxkatie.macs.hw.ac.uk) has joined #arianne
[21:16] <Bluelads4> :)
[21:17] <kymara> if i stay in the same zone i can get the map more than once from him
[21:17] <CIA-19> arianne_rpg: madmetzger * stendhal/src/games/stendhal/server/ (3 files in 2 dirs): try to use zone storage for trade offers
[21:17] <kymara> but if i change zone then come back for it, he doesn't give it
[21:17] <madmetzger> kymara: my tries on the zone storage
[21:17] <kymara> i wanted to know where the server tells the client to open the image
[21:17] <kymara> cool ok
[21:18] <kymara> that's why i was looking for what addEvent was, as i couldn't see where the server tells the client
[21:18] <madmetzger> ah, now i understand your problem.
[21:18] <kymara> i'm just trying to debug in my clumsy way
[21:19] <madmetzger> the server just sends an rpaction over the connection and the client deals with this action
[21:19] <kymara> and trying to find reliable ways to reproduce the bug
[21:19] <kymara> i've dealt with rpactions but i don't see it in this code
[21:19] <madmetzger> should be somewhere in the client packages imho
[21:19] <kymara> then there's usually something analogous on the server side
[21:19] <kymara> *frowns*
[21:20] <kymara> i look at server/entity/npc/action/ExamineChatAction and server/events/ExamineEvent
[21:20] <kymara> neither have anything like the player rpaction i'm used to
[21:23] [freenode-connect VERSION]
[21:23] <kymara> do you know what i'm talking about? i just wanted to see where the server side code tells the client to open the image
[21:24] <kymara> i'll just fallback to grep :P
[21:24] <madmetzger> yes... i already used this
[21:25] <madmetzger> maybe a good start would be NPC-class for monogenes?
[21:25] <madmetzger> then you'll see how the npc tells server side the client how to deal with the map?
[21:25] <kymara> what?
[21:25] <kymara> why?
[21:26] <kymara> no, it looks like it's all hidden within the rp event stuff in fact
[21:26] * Bluelads4 (i=5084d462@gateway/web/ajax/mibbit.com/x-d4798186f4842c72) has left #arianne
[21:26] <kymara> monogenes simply has a chat action ExaminechatAction
[21:26] <kymara> i don't know how that helps me
[21:26] <kymara> i look at ExaminechatAction
[21:26] <madmetzger> i think that would help, because he reacts on "map"
[21:26] <madmetzger> so he should have behaviour for that
[21:26] <kymara> yes, and he does react correctly for teh text part
[21:26] <kymara> it's the image which doesn't show
[21:26] <kymara> yes, he does
[21:26] <kymara> he says the caption
[21:27] <kymara> you're frustrating me
[21:27] <madmetzger> and nothing more?
[21:27] <kymara> argh
[21:27] <kymara> you SAW this bug
[21:27] <kymara> you were in game
[21:27] <kymara> you logged in and tried it
[21:27] <yoriy> hm, Ilisa shows image too
[21:27] <kymara> well actually she doesn't yoriy and that's part of the bug
[21:28] <kymara> it's a problem in general in examinechataction which is why i'm investigating
[21:28] <kymara> anyway don't worry i found out how server tells client
[21:28] <kymara> it is hidden in teh event stuff
[21:28] <kymara> addEvent, a marauroa method, has created an rpevent, and then there's a client side check: if (rpevent.getName().equals("examine"))
[21:28] <kymara> so, that's fine, i'll go look over there
[21:29] <madmetzger> sorry, i did not want to frustrate you
[21:30] <madmetzger> i was just trying to point out my ideas where to have a look and try to follow the way from server to client
[21:31] <kymara> ok. it's just i know all those npcs use examinechataction to show the image
[21:31] <kymara> and it's that action which isn't functioning
[21:32] <madmetzger> yes
[21:32] <madmetzger> but i do not find the corresponding client side code
[21:32] <madmetzger> now i get frustrated, because i can't find it
[21:36] <kymara> oh, that was from UserContext,java
[21:36] <kymara> .
[21:36] <kymara> i did a case insensitive grep for examine in the client source
[21:37] <kymara> after i've found the files then i usually look through the recent changes to try work out what changed
[21:39] <kymara> the UserContext stuff hints that the ImageViewer itself is at package games.stendhal.client.gui.imageviewer
[21:40] <kymara> hendrik would be interested in this bug since it seems to be about rpevents and zone changes :)
[21:41] <yoriy> is it will be better, get old stendhal version from cvs, and then learn what was changed?
[21:41] <yoriy> i mean version where images working
[21:41] <madmetzger> it depends... ;-)
[21:41] <madmetzger> in some cases it helps
[21:42] <yoriy> well :-)
[21:42] <kymara> yes sometimes kiheru does that. well he builds it himself since he has all of cvs history ever
[21:43] <madmetzger> kymara: there is a test case for ImageViewer
[21:43] <kymara> to pinpoint exactly where it got introduced, but usually one needs to have a good idea first
[21:43] <madmetzger> that's right.
[21:43] <kymara> madmetzger: does the test case test what happens if the player changes zone then comes back and asks again?
[21:43] <yoriy> ok, guys :-) will c u tomorrow again :-) bye now :-)
[21:43] <kymara> because, that's the time the bug seems to be happening
[21:43] <kymara> so if it doesn't, it might not be a helpful one here
[21:43] <kymara> night yoriy
[21:43] <madmetzger> no
[21:44] <yoriy> good night
[21:44] * yoriy (n=opera@81.16.113.174) has left #arianne
[21:44] <madmetzger> i am just looking at it
[21:44] <madmetzger> and it tests nothing really
[21:46] <madmetzger> games.stendhal.client.gui.imageviewer.RPEventImageViewer does the work, i think
[21:47] <madmetzger> but i think you are that far...
[21:47] <madmetzger> right kymara?
[21:47] <kymara> yes, and have been looking for changes, but no avail
[21:47] <kymara> i mean i still think it could equallybe a server side or even marauroa problem
[21:49] <madmetzger> hm... i could test with my local eclipse, too.
[21:51] <kymara> actually, i'm thinking it *is* client side
[21:51] <kymara> cos if i ask for map, i get it, then i change zone, go back and ask again, don't get it
[21:52] <kymara> then i log out and i can get it again when i return
[21:52] <kymara> sounds client-y doesn't it?
[21:52] <madmetzger> hm... difficult to say
[21:53] <madmetzger> my first try did not show map after going to monogenes
[21:53] <kymara> when? today?
[21:54] <madmetzger> right now with my local cvs-client
[21:54] <kymara> ah, but did you have to zone change to get there?
[21:54] <madmetzger> yes
[21:55] <kymara> it's same for me, if i login outside smeos then go to him i dont get it first try either
[21:55] <madmetzger> but i get his description
[21:55] <kymara> yes that isn't part of the rp event at all
[21:55] <kymara> that's part of the fsm engine thingy
[21:56] <madmetzger> no event comes to the client, as i set a breakpoint to RPEventImageViewer.viewImage(rpevent);
[21:56] <kymara> that's just what he says, as well as doing the action
[21:56] <kymara> there has been a bug report before about 'events lost on zone change'
[21:56] <madmetzger> so the rpevent does not reach the client
[21:56] <kymara> but i thought that was about events sent in the same turn that you changed zone
[21:56] <kymara> like, if i am being sent to jail and a message gets sent to me about it, i don't get message as the message event was lost on zone change. but if i was in jail then i get it
[21:56] <madmetzger> my next step will be setting breakpoint in the serverside action
[21:57] <kymara> that's what i meant when i said hendrik would like this bug
[21:57] <kymara> ok
[21:57] <madmetzger> *argh* i should start client and server in debug mode
[21:57] <kymara> but this event - if it's lost on zone change - is getting lost before it was even requested? :P
[21:58] <madmetzger> maybe... i am not sure...
[22:03] <madmetzger> i can reproduce your behaviour and the client does not get the event when you return to monogenes after zone change
[22:03] <madmetzger> so the event seems to get lost, as it is built server side
[22:04] <madmetzger> i did what you said kym:
[22:04] <madmetzger> 1. login in semos city, ask mono for map --> map shows
[22:04] <madmetzger> 2. leave zone
[22:04] <madmetzger> 3. return to zone and ask again for map --> no map is shown
[22:05] <kymara> but the server definitely made it?
[22:05] <kymara> because otherwise your breakpoint would have done something?
[22:06] <kymara> https://sourceforge.net/tracker/index.php?func=detail&aid=1938035&group_id=1111&atid=101111 this is the bug
[22:07] <kymara> it was assigned by mblanch to himself for 4 months, i unassign bugs if they're left untouched that long as the assign thing should really mean 'i am working on it' not 'yeah, it's my responsibility, but i don't have time'
[22:07] <madmetzger> yes, the server made it. i had two breakpoints: one serverside at event construction and one at display of view
[22:07] <kymara> (its fine to not have time, but don't give misinformation and let others think it's being dealt with)
[22:07] <kymara> i tried with server having the very latest marauroa and that didn't help
[22:09] <madmetzger> there is certainly a server side problem i think. but i am not sure where it could be located
[22:11] <kymara> brb have to fetch stepsister from work
[22:11] <madmetzger> okay
[22:26] * neoneurone (n=chatzill@shm67-4-82-242-215-135.fbx.proxad.net) Quit ("ChatZilla 0.9.84 [Firefox 3.0.7/2009031120]")
[22:33] * Bluelads4 (i=5084d462@gateway/web/ajax/mibbit.com/x-d4798186f4842c72) has joined #arianne
[22:54] <madmetzger> kymara: we can continue tm
[22:54] * madmetzger (n=markus@g229177028.adsl.alicedsl.de) has left #arianne
[23:07] * durkham (n=astrid@c202046.adsl.hansenet.de) has joined #arianne
[23:26] * Bluelads4 (i=5084d462@gateway/web/ajax/mibbit.com/x-d4798186f4842c72) has left #arianne
[23:39] * Ci-Dev (n=ci-dev@p54BDD10C.dip.t-dialin.net) Quit ("Life makes sense when looking at it backwards, it's just a shame it goes forwards.")
[23:51] <kymara> oops, sorry mad
[23:56] <kymara> madmetzger, i think you'll find that the Offers only come back as marauroa objects after they are stored in the database. so you need to look at src/games/stendhal/server/core/engine/StendhalRPObjectFactory.java
[23:58] <kymara> you'll see the transformerMap, and you need to make a src/games/stendhal/server/core/engine/transformer/OfferTransformer.java to turn the marauroa.common.game.RPObject into an Offer. It'll be an Offer(object) which is why you made public Offer(final RPObject object)
These logs were automatically created by _eye_fill_in on irc.freenode.net using the Java IRC LogBot.