Timestamps are in GMT/BST.
[0:46] <CIA-52> arianne_rpg: kiheru * stendhal/src/games/stendhal/server/maps/quests/ (4 files in 2 dirs):
[0:46] <CIA-52> arianne_rpg: split house buying to a bit smaller chunks. implemented house
[0:46] <CIA-52> arianne_rpg: taxes, and confiscation. added a simple way to pay the
[0:46] <CIA-52> arianne_rpg: taxes to help in testing it. taxman will need a real conversation
[0:46] <CIA-52> arianne_rpg: code instead. also hours are used in place of months for now
[0:46] <CIA-52> arianne_rpg: for testing purposes.
[0:54] * kiheru is now known as kiheru_afk
[0:55] * tigertoes (n=oldpetna@oh-71-50-52-125.dhcp.embarqhsd.net) has joined #arianne
[1:06] * tigertoes (n=oldpetna@oh-71-50-52-125.dhcp.embarqhsd.net) Quit (Read error: 104 (Connection reset by peer))
[1:11] * tigertoes (n=oldpetna@oh-71-50-52-125.dhcp.embarqhsd.net) has joined #arianne
[1:55] * DensFisendi (n=Deus@BAG7732.bag.pppool.de) has joined #arianne
[2:13] * DeusFigendi (n=Deus@BAG4ee4.bag.pppool.de) Quit (Read error: 110 (Connection timed out))
[2:30] <durkham> housebuying test throws NPE
[2:31] <Ci-Dev> durkham: I have to admit that this Ctrl+G is quite handy to find the way around in the source. :)
[2:33] * neoneurone (n=chatzill@shm67-4-82-242-215-135.fbx.proxad.net) Quit ("ChatZilla 0.9.84 [Firefox 3.0.6/2009021619]")
[2:39] <durkham> :-)
[2:45] <durkham> kiheru is there any special reason why you use infostring for the housenumber, name etc storage ?
[2:45] <durkham> you could also make a new RPClass that has attributes to store them
[3:00] * DensFisendi is now known as DeusFigendi
[3:21] <durkham> gnight
[3:22] * durkham (n=astrid@d031205.adsl.hansenet.de) Quit ("Leaving.")
[5:35] * Ci-Dev_ (n=ci-dev@p54BDE59F.dip.t-dialin.net) has joined #arianne
[5:43] * Ci-Dev (n=ci-dev@p54BDE9D0.dip.t-dialin.net) Quit (Read error: 145 (Connection timed out))
[8:36] * madmetzger (n=markus@p5B03EB30.dip.t-dialin.net) has joined #arianne
[9:08] <madmetzger> hm... we have a dependency problem...
[9:08] <madmetzger> ant-target compile_tests depends on compile_tools
[9:09] <madmetzger> but with classes that are compiled in tools, there are code dependencies to the tests and so it does not compile successfully
[9:21] <CIA-52> arianne_rpg: madmetzger * stendhal/build.xml: run_tests work again
[9:24] * kiheru_afk is now known as kiheru
[9:30] <kiheru> the original reason for using infostring was that it's an automatically persistent attribute. Eventually I had to make the keys persistent anyway as there's apparently no other way to have the image depend on the other properties (it gets overwritten after the constructor). other reasons is that I'm quite unwilling to add new attributes when marauroa is so wonderfully fragile when it to comes changing them later. (especially since there's already an a
[9:35] <CIA-52> arianne_rpg: kiheru * stendhal/src/games/stendhal/server/maps/quests/houses/HouseTax.java: taxman is called "Mr Taxman"
[9:46] * durkham (n=astrid@d031205.adsl.hansenet.de) has joined #arianne
[9:49] <durkham> tx for the answer kih
[9:49] <durkham> good morning :-D
[9:50] * Bluelads4 (i=5084eda7@gateway/web/ajax/mibbit.com/x-70aeeca7ebf805b8) has joined #arianne
[9:50] <durkham> i am aware of the fragility of marauroa.
[9:51] <durkham> i am also aware that infostring is widely abused
[9:52] <durkham> mad did prepare code that would enable us to solve those changement problems
[9:52] * Bluelads4 (i=5084eda7@gateway/web/ajax/mibbit.com/x-70aeeca7ebf805b8) Quit ("http://www.mibbit.com ajax IRC Client")
[9:53] <durkham> to be able to embrasse change , that will be a big step forward
[9:54] <durkham> i propose to think of best possible solution, rather than using infostring just because it is there :-)
[10:02] <madmetzger> durkham: what do you think we should do to solve this compiler error? http://pastebin.com/d7f45f45e
[10:02] <madmetzger> it seems to be a dependency problem, as i mentioned before
[10:03] <madmetzger> would it be okay, to move the mocks to tools?
[10:03] <madmetzger> as i need them for the update-thing, too
[10:03] <durkham> we could try to use a proper mock instead
[10:05] <durkham> the MockrpstendhalWorld is one of the quick-and-dirty-make-it-testable solution
[10:05] <madmetzger> same problem is in balacncerp
[10:07] <durkham> as we need in updateplayer the create() feature is propose to create a proper mock for it,
[10:07] <madmetzger> and what with balancerp?
[10:08] <durkham> ust it there too then ?
[10:08] <durkham> use
[10:08] <durkham> where is the problem ?
[10:08] <madmetzger> so you would propose a new mock?
[10:08] <durkham> yes
[10:09] <madmetzger> okay, i can have a look at the current mock and create a new one
[10:09] <durkham> because i dont see why i have to include tools into pass for tests and vv
[10:09] <durkham> pass = path
[10:09] <madmetzger> first one is already the case
[10:10] <madmetzger> and having tools in classpath for test would be okay, imo
[10:10] <madmetzger> but the other way is not that good
[10:10] <durkham> it is already the case AND it causes problems , so that is no argument for anything
[10:11] <durkham> having tools in clathpass, would be inventing an uneeded dependency
[10:12] <madmetzger> no, as if you test certain things, it could be helpful to use some tools
[10:12] * durkham in addition would produce a more weirdo build path stuff for eclipse.
[10:12] <madmetzger> this mock is a good example
[10:13] <madmetzger> the dependency from tests to tools is not causing the problem. the other way is causing it
[10:14] <madmetzger> a tool depends on test
[10:14] <durkham> if you think that is the superior design to do so then do so .
[10:14] * durkham sighs
[10:14] <madmetzger> then i will move the mock to tools
[10:16] <durkham> btw i think balancrp could lve without the player being created by stendhalrpworld
[10:17] <durkham> as it deals with new created players, and does not need the conversion
[10:18] <durkham> the demand for mockstendhalrpworld, arose , when i changed the player creation to use the real create() method in stead of just create one
[10:19] <madmetzger> hm... if i move the mocks to tools, all helpers need to move, too.
[10:19] <durkham> whereas the updater migh or might not need the mockrpworld
[10:19] <madmetzger> i think that is too much
[10:20] <durkham> maybe if you dont use Playertesthelper in the update-thing
[10:20] <madmetzger> i won't move
[10:21] <madmetzger> playertesthelper is not used in the updatething
[10:22] <durkham> well i do not know the code yet
[10:22] * storyteller (i=57b74fd1@gateway/web/ajax/mibbit.com/x-78d9ea6f933e200a) has joined #arianne
[10:22] <durkham> was just guessing, sorry
[10:22] <storyteller> hi all
[10:22] <durkham> hi
[10:23] <madmetzger> no problem. but i think, writing a player specific mock would be okay, too
[10:23] <storyteller> durkham, yesterday I have made a char picture of this confused librarian...^^
[10:23] <durkham> cool
[10:24] <storyteller> ^^
[10:26] <storyteller> shall I upload it to patch tracker?
[10:28] <CIA-52> arianne_rpg: kiheru * stendhal/tests/games/stendhal/server/maps/quests/HouseBuyingTest.java: add taxman to the world to prevent it from collapsing
[10:30] <kiheru> should not npe anymore
[10:41] <durkham> tx kih
[10:42] <durkham> kiheru: do you remember why you had to put mockrp into balancerpgame ?
[10:50] <kiheru> because the real rpworld had started to require db connection (whatch can't be done). I don't remember which methods required the world to be set up. (I tried first getting rid of it entirely; that may be still possible somehow, but I needed the tool runnable again fairly fast)
[10:51] <durkham> thank you kiheru
[10:52] <durkham> i am not critizising i just ask
[10:52] <kiheru> yw
[10:52] <kiheru> I did not take it as criticism :-)
[10:53] <kiheru> (actually you suggested using the mock when I stumbled to that problem :-D )
[10:56] <kiheru> the whole balancer is rather hacky still, even though many parts have been rewritten. it still retains some code I haven't looked at very thoroughtly (the only documentation in the file used to be "NOTE: AWFUL CODE FOLLOWS. YOU ARE NOT SUPPOSED TO READ THIS ;P", and it was one huge method :-D )
[11:03] <durkham> if you are not supposed to read it , you shouldnt use it too :-D
[11:04] <durkham> at least not directed at me , as it was in kawns client side pathfinder :-D
[11:05] <durkham> i am looking into it right now. as it seems to be a piece of code that shows where db access is generated
[11:09] <CIA-52> arianne_rpg: kiheru * stendhal/tiled/Level 0/kalavan/city.tmx: fix for bug [2687043] "fence can be walked"
[11:11] * durkham scratches head
[11:14] <kiheru> deep thought :-D if the balancer could get rid of the world creation entirely, it would simplify things. the tool is not used all that often, so it tends to diverge from the rest of the codebase
[11:16] * durkham catches at the straw
[11:16] <kiheru> I remember looking at how the db connection is established, and found out there's no other way to tell the necessary information to marauroa than using the usual marauroa init stuff... that would be kind of overkill for a tool that does not even need the database
[11:18] <durkham> i remember when i started testing , i was asking (also myself) how to seperate database. and found ti deeply woven into every single part of marauroa and stendahl, without central access point , but provided with reflexion mechansims
[11:18] <durkham> and today i remeber why i tried to forget about it :-D
[11:29] * durkham remembers to have told kiheru to use mockrpworld as a quick and dirty solution because she new Kiheru needed it up again urgently -P
[11:33] <kiheru> now it has come back to haunt you :-P
[11:33] <durkham> make it compile, make it run , chip it :-D
[11:34] <durkham> ship it
[11:34] <durkham> qad always comes back to haunt you :-D
[11:35] <durkham> 1058 [main] WARN games.stendhal.server.entity.npc.parser.WordList - last word of name 'food mill' has unexpected type: mill/VER expected type: OBJ
[11:35] <durkham> gaaaa
[11:35] <kiheru> iirc there was several things within the player setup that crashed without the word :-/
[11:35] <durkham> yes i am setting it up right now :-(
[11:35] <kiheru> world list always comes back to haunt you as well
[11:36] <kiheru> *word
[11:36] <durkham> wordlist found out that 'food' is a verb that is why 'mill' has to be an object
[11:36] <durkham> yarrrr
[11:37] * durkham needs more tables to munch
[11:37] <durkham> I food mill. do you food mill too? Who else foods mill?
[11:38] * storyteller (i=57b74fd1@gateway/web/ajax/mibbit.com/x-78d9ea6f933e200a) Quit ("http://www.mibbit.com ajax IRC Client")
[11:49] <durkham> seems i have to refator the gameevents thingy first :-D
[11:56] <durkham> which will result in another big commit if i can make it :-)
[11:57] <kiheru> would not dsrupt me :-) trying to write some tests for the house keys
[11:58] <kiheru> (and can't remember how to make entitymanager understand that there is such an item)
[12:00] * durkham mumbles another workingplace
[12:01] <durkham> try Mockstendhalrpworld get () :-D
[12:01] <durkham> or get entitymanager and feed him item
[12:03] <kiheru> I do MockStendlRPWorld.get(), but it's not helping :-(
[12:03] <durkham> mockruleprocessor then ?
[12:03] <durkham> one of those is it
[12:04] <durkham> there is a itemsloaderxml called by some of those weirdos
[12:16] <kiheru> works when run with other tests, but not otherwise. I got tired of searching what I should do :-D I'll write some tests and try again a bit later
[12:19] <kiheru> I remember having the exact same problem before with some test, but can't remember what I should call before the tests
[12:20] <durkham> :-(
[12:20] <durkham> welcome to sphaghetti world :-D
[12:20] * durkham is prducing a gameevent ravioli :-)
[12:28] * storyteller (i=57b77c77@gateway/web/ajax/mibbit.com/x-cf26b15bd20a8240) has joined #arianne
[12:30] <kiheru> found the problem. MockStendlRPWorld.get() apparently does the right thing, but for some reason my eclipse does not want to inherit the right paths for individual tests
[12:30] <durkham> oh
[12:31] <durkham> shall i show you mine ?
[12:35] <durkham> http://www.speedyshare.com/260252590.html
[12:35] * durkham is slomo today
[13:18] <CIA-52> arianne_rpg: kiheru * stendhal/tests/games/stendhal/server/entity/item/HouseKeyTest.java: added tests for house keys
[13:24] <durkham> yarrrr
[13:26] <kiheru> house portal could use some tests too, but all the real magic is in saving it to db, and restoring again with all the correct connection information. and that's not so easy to test :-/
[13:36] <durkham> you can simulate that
[13:37] <durkham> ahh that was too fast sorry :-D
[13:38] <durkham> it is somewhere in the write() method of rpobject
[13:38] <durkham> lunch now
[13:40] <kiheru> it's not so much the problem to test if it saves the data, but ttesting that it's the right data so that zone can properly restore the links to the other portals
[13:42] <kiheru> I think I'll leave those parts without tests. better that it's obviously untested, than a fake 100% coverage that does not test the things that matter
[13:52] * madmetzger (n=markus@p5B03EB30.dip.t-dialin.net) has left #arianne
[13:56] * storyteller (i=57b77c77@gateway/web/ajax/mibbit.com/x-cf26b15bd20a8240) Quit ("http://www.mibbit.com ajax IRC Client")
[14:04] * Ci-Dev_ is now known as Ci-Dev
[14:25] * neoneurone (n=chatzill@shm67-4-82-242-215-135.fbx.proxad.net) has joined #arianne
[14:34] * Mein_Dino (i=5b4259a0@gateway/web/ajax/mibbit.com/x-c391c93fec757058) has joined #arianne
[14:34] <Mein_Dino> Hello everyone ;)
[14:38] * dsafhadfh (n=askdfgj@91-66-89-160-dynip.superkabel.de) has joined #arianne
[14:38] * Mein_Dino (i=5b4259a0@gateway/web/ajax/mibbit.com/x-c391c93fec757058) Quit (Client Quit)
[14:38] * dsafhadfh is now known as Mein_Dino
[14:38] <CIA-52> arianne_rpg: kiheru * stendhal/tests/games/stendhal/server/entity/mapstuff/portal/HousePortalTest.java: Made some tests for HousePortal. Everything about restoring is still untested.
[14:44] <durkham> kiheru you can still test the converter, if it works as expected. at somepoint you have to trust the framework you work with.
[14:45] <durkham> so if the rpobject is fed into converter (which works btw) you can see if convertion is processed corrrectly
[14:45] <durkham> the creation of the rpobject has to be ( if so ) tested in marauroa anyway
[14:53] <kiheru> I could try testing some things about it. I did the easy things first
[14:55] * Mein_Dino is now known as dino^afk
[14:55] <durkham> i appreciate all tests written :-)
[14:55] * durkham huggels kiheru
[14:55] * kiheru hugs durkham
[14:56] * dino^afk slaps durkham around a bit with a large trout
[14:56] <kiheru> I have a bad habit of forgetting them
[14:56] <dino^afk> huch ^^
[14:58] <durkham> dino^afk: we dont like ths here if you cant help it please use #arianne-chat :-D
[14:58] <durkham> i run them frequently
[15:01] <Ci-Dev> What did dino do?
[15:02] <Ci-Dev> Oh, the slap.
[15:02] <Ci-Dev> Never mind. :)
[15:03] <dino^afk> ;)
[15:03] <Ci-Dev> I've seen the commit of HousePortal in the Minimap... why not put it together with the (regular) Portals? this portal.isHidden() never triggers anyway, I got told by kymara.
[15:03] <Ci-Dev> (out of context, by the way)
[15:06] <Ci-Dev> No comment on that?
[15:13] <durkham> probably because , the person who coded had to rewind all the design issues, that led into creating a new class for something that does new things ?
[15:14] <durkham> and maybe 3 minutes is not a long time to wait
[15:15] <Ci-Dev> No, I mean the check for display in minimap.
[15:15] <Ci-Dev> No the need of a new Portal class.
[15:18] <kiheru> it could perhaps be derived from Portal (like it's in server side)
[15:19] <durkham> if it can be done without deriving on client side i would be happy to have it like that
[15:19] <kiheru> but a different class *is* needed, since the house portal needs "look" in its menu, unlike the other portals
[15:20] <kiheru> (the other choise would be polluting Portal with house portal specific code, which does not sound good)
[15:20] <durkham> i would also like to invent a new attribute / slot on server side that gives a hint of changed states , so client does not need to know stuff about the structue of the object but coud look for getInt(state) to decide on row of animation
[15:26] <kiheru> I don't know what you mean? that the server should tell the client how to animate an item?
[15:28] <durkham> we have items onserver side that change states
[15:28] <durkham> like door and ring of life aso
[15:28] <durkham> they all provide different attributes to indicate it has changed
[15:29] <durkham> it would be easier if they were using a common attribute to indicate state change
[15:36] <kiheru> I suppose that would be doable.
[16:48] * Bluelads4 (i=5084eda7@gateway/web/ajax/mibbit.com/x-4faf86de5ee19289) has joined #arianne
[17:01] * kiheru is now known as kiheru_afk
[17:12] * durkham (n=astrid@d031205.adsl.hansenet.de) Quit ("Leaving.")
[17:26] * Disconnected.
[17:26] -NickServ- This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.
[17:26] * _eye_fill_in (n=PircBot@d068015.adsl.hansenet.de) has joined #arianne
[17:26] * Topic is 'Stendhal 0.72 and Marauroa 2.6 released: http://arianne.sourceforge.net/?arianne_url=games/game_stendhal#downloadsection][ public server: http://stendhal.game-host.org ][ want to chat?: /join #arianne-chat ][ ANY QUESTIONS?: Just ask them and stick around in the channel, maybe an answer will pop up later ]'
[17:26] * Set by kymara on Sun Feb 22 23:37:04 CET 2009
[18:35] * durkham (n=astrid@d068015.adsl.hansenet.de) has joined #arianne
[19:15] <CIA-52> arianne_rpg: astridemma * stendhal/ (49 files in 17 dirs): asynchronous handling of gameevents via concurrentqueue
[19:56] <CIA-52> arianne_rpg: kiheru * stendhal/src/games/stendhal/server/maps/quests/houses/HouseTax.java:
[19:56] <CIA-52> arianne_rpg: fixed a typo that resulted in interest rate 0. refactored the methods
[19:56] <CIA-52> arianne_rpg: a bit to give access to tax debt calculation from outside. (needed by
[19:56] <CIA-52> arianne_rpg: house selling)
[20:07] <postman-bot> Bluelads4 rented a sign saying "hi :) I'm searching for a golden helmet... is anybody there who can sell one to me? :)"
[20:07] * madmetzger (n=markus@g230015027.adsl.alicedsl.de) has joined #arianne
[20:13] <Ci-Dev> Is there a way to get a list of *free* houses?
[20:14] <Ci-Dev> The seller says 26-49... and one has to spam all numbers.
[20:14] <Ci-Dev> Just to figure out that all houses are sold.
[20:14] <Ci-Dev> What about he just names the free house numbers?
[20:16] <kiheru_afk> not yet. it's planned for the next version
[20:16] * kiheru_afk is now known as kiheru
[20:16] <Ci-Dev> Fine. :)
[20:16] <kiheru> (also in the next version all free houses will have "For sale!" description in their door)
[20:16] <Ci-Dev> Awesome. :D
[21:45] * madmetzger (n=markus@g230015027.adsl.alicedsl.de) has left #arianne
[22:33] * Bluelads4 (i=5084eda7@gateway/web/ajax/mibbit.com/x-4faf86de5ee19289) has left #arianne
[22:49] <CIA-52> arianne_rpg: astridemma * stendhal/src/games/stendhal/server/ (5 files in 3 dirs): asynchronous handling of ItemLogging via concurrentqueue (not completly but better) retrieving item DB ID is still not handled asynchronously .
[22:52] * neoneurone (n=chatzill@shm67-4-82-242-215-135.fbx.proxad.net) Quit ("ChatZilla 0.9.84 [Firefox 3.0.6/2009021619]")
[22:57] <durkham> hendrik really did a good job when he assembled it in one place -)
[23:06] <dino^afk> good night to all ;) cu
[23:07] * dino^afk (n=askdfgj@91-66-89-160-dynip.superkabel.de) Quit ()
[23:10] <durkham> kiheru: in balancerpgame the player has no weapon equipped, is that deliberately ?
[23:11] <CIA-52> arianne_rpg: kiheru * stendhal/src/games/stendhal/server/maps/quests/houses/HouseBuyingMain.java:
[23:11] <CIA-52> arianne_rpg: pay a player who sells a house. don't change locks when a player
[23:11] <CIA-52> arianne_rpg: buys one; the house is already inaccessible to others
[23:13] <durkham> i will commit the new version in a second
[23:15] <kiheru> I think I did not touch that part of the code. better not change it or the balancer needs to be rebalanced
[23:15] <kiheru> (and after that all the creatures)
[23:15] <CIA-52> arianne_rpg: astridemma * stendhal/ (4 files in 3 dirs):
[23:15] <CIA-52> arianne_rpg: moved RPClass generation into own class.
[23:15] <CIA-52> arianne_rpg: make BalanceRPGame independent from world and zone :-)
[23:15] <kiheru> yay
[23:15] <durkham> :-)
[23:17] <durkham> all things i did today are a bit scary as cannot test it under heavy load :-(
[23:18] <durkham> all tests work i did my very best to watch the db after changes .
[23:40] <CIA-52> arianne_rpg: kiheru * stendhal/src/games/stendhal/server/script/HousesFromPostman.java: add a note to the house owner and presets to the chest
[23:47] <CIA-52> arianne_rpg: astridemma * stendhal/src/games/stendhal/tools/GenerateMonsterUsage.java: do not suppress the needed out put
These logs were automatically created by _eye_fill_in on irc.freenode.net using the Java IRC LogBot.